AndrewJSchofield commented on code in PR #18735:
URL: https://github.com/apache/kafka/pull/18735#discussion_r1933669845


##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -1783,12 +1782,14 @@ public void 
testDescribeTopicsWithDescribeTopicPartitionsApiErrorHandling() thro
         }
     }
 
-    @Flaky("KAFKA-18441")
     @Test
     public void testAdminClientApisAuthenticationFailure() {
         Cluster cluster = mockBootstrapCluster();
         try (final AdminClientUnitTestEnv env = new 
AdminClientUnitTestEnv(Time.SYSTEM, cluster,
-                newStrMap(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG, 
"1000"))) {
+                newStrMap(AdminClientConfig.REQUEST_TIMEOUT_MS_CONFIG, "1000",
+                    // The default "retry.backoff.ms" is 100. if following 
assertion can't finish in 100L,
+                    // the test will fail. Set it to 5000 to make sure the 
test can finish in time.
+                    AdminClientConfig.RETRY_BACKOFF_MS_CONFIG, "5000"))) {
             env.kafkaClient().setNodeApiVersions(NodeApiVersions.create());
             
env.kafkaClient().createPendingAuthenticationError(cluster.nodes().get(0),
                     TimeUnit.DAYS.toMillis(1));

Review Comment:
   This is the suspicious part I think. I think the intent of the code was to 
have an authentication error which lasted for 1 day, giving plenty of time for 
the other tests to run. In fact, the code in `MockClient` doesn't appear to do 
that, and the value of the `TimeUnit.DAYS.toMillis(1)` is questionable.



##########
clients/src/test/java/org/apache/kafka/clients/admin/KafkaAdminClientTest.java:
##########
@@ -1783,12 +1782,14 @@ public void 
testDescribeTopicsWithDescribeTopicPartitionsApiErrorHandling() thro
         }
     }
 
-    @Flaky("KAFKA-18441")

Review Comment:
   I don't think this `@Flaky` should be removed until we have evidence that 
this has properly fixed the flakiness in the CI. I would wait for 7 days of 
clean builds before removing it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to