AndrewJSchofield commented on code in PR #18725:
URL: https://github.com/apache/kafka/pull/18725#discussion_r1933895394
##########
core/src/main/java/kafka/server/share/DelayedShareFetch.java:
##########
@@ -68,7 +68,14 @@ public class DelayedShareFetch extends DelayedOperation {
private LinkedHashMap<TopicIdPartition, Long> partitionsAcquired;
private LinkedHashMap<TopicIdPartition, LogReadResult>
partitionsAlreadyFetched;
- DelayedShareFetch(
+ /**
+ * This function returns an instance of delayed share fetch operation for
completing share fetch requests instantaneously or with delay.
Review Comment:
Constructs rather than returns I think.
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -1106,8 +1106,9 @@ boolean canAcquireRecords() {
* the records are fetched and acquired.
*
* @return A boolean which indicates whether the fetch lock is acquired.
+ * Visible for testing.
Review Comment:
If you look at the javadoc, this sentence is part of the description for the
return value. Either remove "Visible for testing" (preferred) or make sure it
fits in the javadoc more nicely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
