apoorvmittal10 commented on code in PR #18672:
URL: https://github.com/apache/kafka/pull/18672#discussion_r1933892015
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -172,73 +172,58 @@ public PollResult poll(long currentTimeMs) {
k -> sessionHandlers.computeIfAbsent(node.id(), n ->
new ShareSessionHandler(logContext, n, memberId)));
TopicIdPartition tip = new TopicIdPartition(topicId,
partition);
- Acknowledgements acknowledgementsToSend =
fetchAcknowledgementsToSend.remove(tip);
- if (acknowledgementsToSend != null) {
-
metricsManager.recordAcknowledgementSent(acknowledgementsToSend.size());
- fetchAcknowledgementsInFlight.put(tip,
acknowledgementsToSend);
+ Acknowledgements acknowledgementsToSend = null;
+ Map<TopicIdPartition, Acknowledgements>
nodeAcknowledgementsMap = fetchAcknowledgementsToSend.get(node.id());
Review Comment:
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
