AndrewJSchofield commented on code in PR #18672:
URL: https://github.com/apache/kafka/pull/18672#discussion_r1933861531


##########
clients/src/main/java/org/apache/kafka/clients/consumer/AcknowledgementCommitCallback.java:
##########
@@ -42,12 +44,16 @@ public interface AcknowledgementCommitCallback {
      *
      * @param exception The exception thrown during processing of the request, 
or null if the acknowledgement completed successfully.
      * <p><ul>
+     * <li> {@link AuthorizationException} if not authorized to the topic or 
group
      * <li> {@link InvalidRecordStateException} if the record state is invalid
-     * <li> {@link AuthorizationException} if not authorized to the topic of 
group
+     * <li> {@link NotLeaderOrFollowerException} if the leader had changed by 
the time the acknowledgements were sent
+     * <li> {@link DisconnectException} if the broker disconnected before the 
request could be completed
      * <li> {@link WakeupException} if {@link KafkaShareConsumer#wakeup()} is 
called before or while this function is called
      * <li> {@link InterruptException} if the calling thread is interrupted 
before or while this function is called
      * <li> {@link KafkaException} for any other unrecoverable errors
      * </ul>
+     * <p>Note that if the exception is a retriable exception, the 
acknowledgement could not be completed and the

Review Comment:
   I will reword.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to