mjsax commented on code in PR #18721:
URL: https://github.com/apache/kafka/pull/18721#discussion_r1931421470
##########
streams/src/main/java/org/apache/kafka/streams/kstream/internals/KStreamKTableJoinProcessor.java:
##########
@@ -42,24 +42,24 @@
import static
org.apache.kafka.streams.processor.internals.metrics.TaskMetrics.droppedRecordsSensor;
import static org.apache.kafka.streams.state.ValueAndTimestamp.getValueOrNull;
-class KStreamKTableJoinProcessor<K1, K2, V1, V2, VOut> extends
ContextualProcessor<K1, V1, K1, VOut> {
+class KStreamKTableJoinProcessor<K, V, KTable, VTable, VOut> extends
ContextualProcessor<K, V, K, VOut> {
Review Comment:
Flipping type order -- no splash radius -- change limited to this line only,
but diff is weird.
Effectively renaming `K1 -> KStream`, `V1 -> VStream`, `K2 -> KTable`, and
`V2 -> VTable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
