adixitconfluent commented on code in PR #18696:
URL: https://github.com/apache/kafka/pull/18696#discussion_r1930314734
##########
core/src/main/java/kafka/server/share/SharePartition.java:
##########
@@ -462,6 +474,10 @@ public CompletableFuture<Void> maybeInitialize() {
// in the cached state are not missed
findNextFetchOffset.set(true);
endOffset =
cachedState.lastEntry().getValue().lastOffset();
+ // initialReadGapOffset is not required, if there are no
gaps in the read state response
+ if (isGapPresentInStateBatches) {
+ initialReadGapOffset = new
InitialReadGapOffset(endOffset, startOffset);
Review Comment:
@chirag-wadhwa5, in the case when the gaps are in between and not at the
beginning, we shouldn't keep the `gapStartOffset` as `startOffset` but it
should be from where the gap starts. I understand that this will change the
nextFetchOffset() logic code change, but do you think this will be a feasible
approach?
cc - @apoorvmittal10
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
