apoorvmittal10 commented on code in PR #18696: URL: https://github.com/apache/kafka/pull/18696#discussion_r1928978527
########## core/src/test/java/kafka/server/share/SharePartitionTest.java: ########## @@ -5752,13 +5752,13 @@ public void testMaybeInitializeWhenReadStateRpcReturnsZeroAvailableRecords() { for (int i = 0; i < 500; i++) { stateBatches.add(new PersisterStateBatch(234L + i, 234L + i, RecordState.ACKNOWLEDGED.id, (short) 1)); } - stateBatches.add(new PersisterStateBatch(232L, 232L, RecordState.ARCHIVED.id, (short) 1)); + stateBatches.add(new PersisterStateBatch(233L, 233L, RecordState.ARCHIVED.id, (short) 1)); Review Comment: Don't we require more tests as previously we didn't find the problem in share partition? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org