ijuma commented on PR #18602: URL: https://github.com/apache/kafka/pull/18602#issuecomment-2599751995
Makes sense to use the `testkit` name for the external dependency and going with `util` for a more general module name that can include shared junit stuff but also other useful things needed by all test modules. The only open question for me is the `test-common-api` name. Even though it makes sense, we typically use `api` for modules that expose apis externally (`group-coordinator-api`, `storage-api`, `tools-api`, etc.). In this case, it's a purely internal module, so I wonder if we can find a different name to describe it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
