AndrewJSchofield commented on code in PR #18521:
URL: https://github.com/apache/kafka/pull/18521#discussion_r1916230689
##########
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##########
@@ -1922,6 +1918,38 @@ private void warmup() throws InterruptedException {
}
}
+ private void verifyShareGroupStateTopicRecordsProduced() {
+ try {
+ TestUtils.waitForCondition(() ->
+
!cluster.brokers().get(0).metadataCache().getAliveBrokerNodes(new
ListenerName("EXTERNAL")).isEmpty(),
+ DEFAULT_MAX_WAIT_MS, 100L, () -> "cache not up yet");
+ Map<String, Object> consumerConfigs = new HashMap<>();
+ consumerConfigs.put(ConsumerConfig.BOOTSTRAP_SERVERS_CONFIG,
cluster.bootstrapServers());
+ consumerConfigs.put(ConsumerConfig.GROUP_ID_CONFIG,
UUID.randomUUID().toString());
Review Comment:
I think you can remove the group.id config too because of the use of
KafkaConsumer.assign.
##########
core/src/test/java/kafka/test/api/ShareConsumerTest.java:
##########
@@ -123,7 +123,7 @@ public void createCluster(TestInfo testInfo) throws
Exception {
.setConfigProp("group.coordinator.rebalance.protocols",
"classic,consumer,share")
.setConfigProp("group.share.enable", "true")
.setConfigProp("group.share.partition.max.record.locks", "10000")
- .setConfigProp("group.share.persister.class.name",
persisterClassName)
+ .setConfigProp("group.share.persister.class.name",
DEFAULT_STATE_PERSISTER)
Review Comment:
This is the default. Not required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
