lianetm commented on code in PR #17964:
URL: https://github.com/apache/kafka/pull/17964#discussion_r1862251816
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java:
##########
@@ -68,7 +68,7 @@ public boolean allowAutoTopicCreation() {
@Override
public synchronized MetadataRequest.Builder newMetadataRequestBuilder() {
- if (subscription.hasPatternSubscription())
+ if (subscription.hasPatternSubscription() ||
subscription.hasRe2JPatternSubscription())
Review Comment:
when the member gets the assignment (with topic Ids only), it requests a
metadata update. If not requesting all topics, that metadata request will only
include the topic names from the subscription (empty at this point).
https://github.com/apache/kafka/blob/e1ba01d21440a1de011c116a0bb6933656200009/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java#L74
From the client point of view, we only have a pattern, and a list of topic
IDs received in assignment, so requesting metadata for all topics. Makes sense?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
