dajac commented on code in PR #17964:
URL: https://github.com/apache/kafka/pull/17964#discussion_r1861710406
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ConsumerMetadata.java:
##########
@@ -68,7 +68,7 @@ public boolean allowAutoTopicCreation() {
@Override
public synchronized MetadataRequest.Builder newMetadataRequestBuilder() {
- if (subscription.hasPatternSubscription())
+ if (subscription.hasPatternSubscription() ||
subscription.hasRe2JPatternSubscription())
Review Comment:
Why do we need to request all topics here? When a new regex is used, it is
not different from subscribing to topic names from the consumer perspective as
the consumer just receives some newly assigned topic id-partitions in both
cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
