cadonna commented on code in PR #17795:
URL: https://github.com/apache/kafka/pull/17795#discussion_r1858464664
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/StreamsGroupHeartbeatRequestManager.java:
##########
@@ -126,7 +113,7 @@ public NetworkClientDelegate.PollResult poll(long
currentTimeMs) {
"messages. You can address this either by increasing
max.poll.interval.ms or by " +
"reducing the maximum size of batches returned in poll() with
max.poll.records.");
- membershipManager.transitionToSendingLeaveGroup(true);
+ membershipManager.onPollTimerExpired();
Review Comment:
I was not satisfied with the existing names since they were not descriptive
enough. In this specific case, it also allowed to make
`transitionToSendingLeaveGroup()` private and to not expose the boolean
parameter that made the code a bit harder to read.
Why is it beneficial to not rename the things too much?
I think we should rename if it makes the code clearer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
