cadonna commented on code in PR #17795:
URL: https://github.com/apache/kafka/pull/17795#discussion_r1858488034
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/StreamsMembershipManagerTest.java:
##########
@@ -781,43 +889,6 @@ private void
setupStreamsAssignmentInterfaceWithTwoSubtopologies(final String su
);
}
- private void
setupStreamsAssignmentInterfaceWithTwoConcatenedSubtopologies(final String
subtopologyId1,
-
final String topicName1,
-
final String subtopologyId2,
-
final String topicName2) {
- when(streamsAssignmentInterface.subtopologyMap()).thenReturn(
- mkMap(
- mkEntry(
- subtopologyId1,
- new StreamsAssignmentInterface.Subtopology(
- Set.of(topicName1),
- Collections.emptySet(),
- Collections.emptyMap(),
- Collections.emptyMap(),
- Collections.emptyList()
- )
- ),
- mkEntry(
- subtopologyId2,
- new StreamsAssignmentInterface.Subtopology(
- Set.of(topicName2),
- Collections.emptySet(),
- mkMap(mkEntry(
- topicName2,
- new StreamsAssignmentInterface.TopicInfo(
- Optional.empty(),
- Optional.empty(),
- Collections.emptyMap()
- )
- )),
- Collections.emptyMap(),
- Collections.emptyList()
- )
- )
- )
- );
- }
-
Review Comment:
Dunno.
For now, I did not see value in also having tests with this setup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
