chia7712 commented on code in PR #17684:
URL: https://github.com/apache/kafka/pull/17684#discussion_r1855219609


##########
generator/src/main/java/org/apache/kafka/message/checker/MetadataSchemaCheckerTool.java:
##########
@@ -81,6 +90,23 @@ public static void run(
                         ", and path2: " + path2);
                 break;
             }
+            case "verify-evolution-git": {
+                String filePath = 
"/metadata/src/main/resources/common/metadata/" + namespace.getString("file");
+                Path rootKafkaDirectory = Paths.get("").toAbsolutePath();
+                while (!rootKafkaDirectory.endsWith("kafka")) {

Review Comment:
   this condition depends on the project folder name. What we're actually 
looking for is the Git folder, so maybe we could change the condition to `while 
(!new File(rootKafkaDirectory.toFile(), ".git").exists())`, which would allow 
us to use a different folder name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to