cmccabe commented on code in PR #17684:
URL: https://github.com/apache/kafka/pull/17684#discussion_r1842897550


##########
generator/src/main/java/org/apache/kafka/message/checker/MetadataSchemaCheckerTool.java:
##########
@@ -81,8 +103,18 @@ public static void run(
                         ", and path2: " + path2);
                 break;
             }
+            case "verify-evolution-git": {
+                String fileCheckMetadata = namespace.getString("file");
+                String gitContent = GetDataFromGit(fileCheckMetadata);
+                EvolutionVerifier verifier = new EvolutionVerifier(
+                        
CheckerUtils.readMessageSpecFromFile(Paths.get("").toAbsolutePath().getParent() 
+ "/metadata/src/main/resources/common/metadata/" + fileCheckMetadata),

Review Comment:
   If we know where the git repo root is, why can't we just change to that 
directory rather than requiring a specific current working directory?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to