tinaselenge commented on code in PR #17524:
URL: https://github.com/apache/kafka/pull/17524#discussion_r1850818864
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3611,12 +3611,17 @@ class KafkaApis(val requestChannel: RequestChannel,
clusterId,
() => {
val brokers = new
DescribeClusterResponseData.DescribeClusterBrokerCollection()
-
metadataCache.getAliveBrokerNodes(request.context.listenerName).foreach { node
=>
+ val describeClusterRequest = request.body[DescribeClusterRequest]
+ metadataCache.getBrokerNodes(request.context.listenerName).foreach {
node =>
+ if (node.isFenced &&
!describeClusterRequest.data().includeFencedBrokers()) {
+ } else {
Review Comment:
I removed the else and swapped the condition around
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
