showuon commented on code in PR #17524:
URL: https://github.com/apache/kafka/pull/17524#discussion_r1850144676
##########
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java:
##########
@@ -2554,6 +2557,10 @@ boolean handleUnsupportedVersionException(final
UnsupportedVersionException exce
return false;
}
+ if (exception.getMessage().contains("Including fenced broker
endpoints is not supported with version")) {
+ return false;
+ }
+
useMetadataRequest = true;
return true;
Review Comment:
So, in
[KIP-700](https://cwiki.apache.org/confluence/display/KAFKA/KIP-700%3A+Add+Describe+Cluster+API),
we implement a fallback to metadata request mechanism when describe cluster
failed with unsupported version. So if we failed due to `Including fenced
broker endpoints is not supported with version`, shouldn't we fallback to use
metadata request? And the follow-up question, what will it be in the admin
client result?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
