dajac commented on code in PR #17834:
URL: https://github.com/apache/kafka/pull/17834#discussion_r1848082524
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -76,7 +76,9 @@ public class GroupCoordinatorConfig {
public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG =
"group.coordinator.rebalance.protocols";
public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC =
"The list of enabled rebalance protocols. Supported protocols: " +
-
Arrays.stream(Group.GroupType.values()).map(Group.GroupType::toString).collect(Collectors.joining(","))
+ ". " +
+ Arrays.stream(Group.GroupType.values())
+ .filter(protocol ->
!protocol.equals(Group.GroupType.UNKNOWN))
+
.map(Group.GroupType::toString).collect(Collectors.joining(", ")) + ". " +
Review Comment:
Yeah, we should definitely hide unknown. My point was more about removing
explicitly mentioning the types in the doc string as they are automatically
displayed. We basically show the same list twice in your screenshot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
