m1a2st commented on code in PR #17834:
URL: https://github.com/apache/kafka/pull/17834#discussion_r1847831451
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -76,7 +76,9 @@ public class GroupCoordinatorConfig {
public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_CONFIG =
"group.coordinator.rebalance.protocols";
public static final String GROUP_COORDINATOR_REBALANCE_PROTOCOLS_DOC =
"The list of enabled rebalance protocols. Supported protocols: " +
-
Arrays.stream(Group.GroupType.values()).map(Group.GroupType::toString).collect(Collectors.joining(","))
+ ". " +
+ Arrays.stream(Group.GroupType.values())
+ .filter(protocol ->
!protocol.equals(Group.GroupType.UNKNOWN))
+
.map(Group.GroupType::toString).collect(Collectors.joining(", ")) + ". " +
Review Comment:
Literally speaking, "unknown" is a recognizable type. But physically,
"unknown" is not a supported protocol. In the user documentation, we should
hide abnormal settings.
Thus I think we should remove it on the document, WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
