chia7712 commented on code in PR #17670:
URL: https://github.com/apache/kafka/pull/17670#discussion_r1835100820
##########
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##########
@@ -204,10 +205,19 @@ abstract class QuorumTestHarness extends Logging {
TestInfoUtils.isShareGroupTest(testInfo)
}
- def maybeGroupProtocolSpecified(testInfo: TestInfo): Option[GroupProtocol] =
{
+ def maybeGroupProtocolSpecified(): Option[GroupProtocol] = {
TestInfoUtils.maybeGroupProtocolSpecified(testInfo)
}
+ def groupProtocolFromTestParameters() = {
+ val gp = maybeGroupProtocolSpecified()
+
+ if (gp.isEmpty)
+ throw new IllegalStateException("Please specify the group.protocol
configuration when creating a KafkaConsumer")
Review Comment:
`maybeGroupProtocolSpecified` is based on the input arguments of test case.
Maybe the error message should be "Please specify the groupProtocol=consumer
when writing the test"
##########
core/src/test/scala/integration/kafka/server/FetchRequestTestDowngrade.scala:
##########
@@ -43,8 +43,9 @@ class FetchRequestTestDowngrade extends BaseRequestTest {
)
}
- @Test
- def testTopicIdIsRemovedFromFetcherWhenControllerDowngrades(): Unit = {
+ @ParameterizedTest(name =
TestInfoUtils.TestWithParameterizedQuorumAndGroupProtocolNames)
+
@MethodSource(Array("getTestQuorumAndGroupProtocolParametersClassicGroupProtocolOnly_ZK_implicit"))
+ def testTopicIdIsRemovedFromFetcherWhenControllerDowngrades(quorum:
String, groupProtocol: String): Unit = {
Review Comment:
This test case is for the ZK-only API (LeaderAndIsrRequest). Not sure if we
plan to remove all ZK-only APIs in 4.0... cc @dajac.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
