dajac commented on code in PR #17233:
URL: https://github.com/apache/kafka/pull/17233#discussion_r1767681365
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicMetadata.java:
##########
@@ -130,45 +107,24 @@ public String toString() {
"id=" + id +
", name=" + name +
", numPartitions=" + numPartitions +
- ", partitionRacks=" + partitionRacks +
')';
}
public static TopicMetadata fromRecord(
ConsumerGroupPartitionMetadataValue.TopicMetadata record
) {
- // Converting the data type from a list stored in the record to a map
for the topic metadata.
- Map<Integer, Set<String>> partitionRacks = new HashMap<>();
- for (ConsumerGroupPartitionMetadataValue.PartitionMetadata
partitionMetadata : record.partitionMetadata()) {
- partitionRacks.put(
- partitionMetadata.partition(),
- Collections.unmodifiableSet(new
HashSet<>(partitionMetadata.racks()))
- );
- }
-
return new TopicMetadata(
record.topicId(),
record.topicName(),
- record.numPartitions(),
- partitionRacks);
+ record.numPartitions());
}
public static TopicMetadata fromRecord(
ShareGroupPartitionMetadataValue.TopicMetadata record
Review Comment:
nit: Not related to your changes but the indentation is incorrect here.
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/TopicMetadata.java:
##########
@@ -130,45 +107,24 @@ public String toString() {
"id=" + id +
", name=" + name +
", numPartitions=" + numPartitions +
- ", partitionRacks=" + partitionRacks +
')';
}
public static TopicMetadata fromRecord(
ConsumerGroupPartitionMetadataValue.TopicMetadata record
) {
- // Converting the data type from a list stored in the record to a map
for the topic metadata.
- Map<Integer, Set<String>> partitionRacks = new HashMap<>();
- for (ConsumerGroupPartitionMetadataValue.PartitionMetadata
partitionMetadata : record.partitionMetadata()) {
- partitionRacks.put(
- partitionMetadata.partition(),
- Collections.unmodifiableSet(new
HashSet<>(partitionMetadata.racks()))
- );
- }
-
return new TopicMetadata(
record.topicId(),
record.topicName(),
- record.numPartitions(),
- partitionRacks);
+ record.numPartitions());
}
public static TopicMetadata fromRecord(
ShareGroupPartitionMetadataValue.TopicMetadata record
) {
- // Converting the data type from a list stored in the record to a map
for the topic metadata.
- Map<Integer, Set<String>> partitionRacks = new HashMap<>();
- for (ShareGroupPartitionMetadataValue.PartitionMetadata
partitionMetadata : record.partitionMetadata()) {
- partitionRacks.put(
- partitionMetadata.partition(),
- Collections.unmodifiableSet(new
HashSet<>(partitionMetadata.racks()))
- );
- }
-
return new TopicMetadata(
record.topicId(),
record.topicName(),
- record.numPartitions(),
- partitionRacks);
+ record.numPartitions());
Review Comment:
nit: ditto.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/Assertions.java:
##########
@@ -242,27 +242,6 @@ private static void assertApiMessageAndVersionEquals(
assertEquals(expectedTopicMetadata.topicId(),
actualTopicMetadata.topicId());
assertEquals(expectedTopicMetadata.topicName(),
actualTopicMetadata.topicName());
assertEquals(expectedTopicMetadata.numPartitions(),
actualTopicMetadata.numPartitions());
-
Review Comment:
I suppose that we can keep this code if we keep the fields in the record.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
