dajac commented on code in PR #17233:
URL: https://github.com/apache/kafka/pull/17233#discussion_r1767103437
##########
group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/SubscribedTopicDescriber.java:
##########
@@ -38,14 +36,4 @@ public interface SubscribedTopicDescriber {
* or -1 if the topic Id does not exist.
*/
int numPartitions(Uuid topicId);
-
- /**
- * Returns all the available racks associated with the replicas of the
given partition.
- *
- * @param topicId Uuid corresponding to the partition's topic.
- * @param partition Partition Id within topic.
- * @return The set of racks corresponding to the replicas of the topic's
partition.
- * If the topic Id does not exist, an empty set is returned.
- */
- Set<String> racksForPartition(Uuid topicId, int partition);
Review Comment:
We cannot remove this from the public interface. Let’s return an empty set
for now.
##########
group-coordinator/src/main/resources/common/message/ConsumerGroupPartitionMetadataValue.json:
##########
@@ -27,14 +27,7 @@
{ "name": "TopicName", "versions": "0+", "type": "string",
"about": "The topic name." },
{ "name": "NumPartitions", "versions": "0+", "type": "int32",
- "about": "The number of partitions of the topic." },
Review Comment:
Same. Unfortunately, we cannot remove fields because we released it. We must
keep it. Let’s put a comment explaining that we don’t use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
