lianetm commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2353248317
Hey @kirktrue , thanks for the updates. Just one comment left for consideration. Also, should we update the PR description? It currently includes: "If the user invokes close() with a low timeout, we need to ensure the above steps are performed even if the UnsubscribeEvent itself timed out", but we're not really ensuring that happens with this PR right? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
