lianetm commented on PR #16686: URL: https://github.com/apache/kafka/pull/16686#issuecomment-2347060544
Hey @kirktrue, thanks for the updates! only comment left above, and: should we add some unit tests for this change? (I guess similar to the existing [testPollThrowsInterruptExceptionIfInterrupted](https://github.com/apache/kafka/blob/300e825be748e6aa55f86f6a6fa588398f1fcc73/clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java#L2098) (the classic consumer does have this covered at the unit test level on the testCloseInterrupt, but seems better to just add a new test instead of trying to tweak that one for the new consumer I would say, it involves much more than the interrupt logic we're interesting in with this PR, but up to you). Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
