ShivsundarR opened a new pull request, #17136:
URL: https://github.com/apache/kafka/pull/17136

   *What*
   Currently the code in `ShareConsumeRequestManager` works on the basis that 
there can only be one `commitSync()`/`close()` at a time. But there is a chance 
these calls timeout on the application thread, but are still sent later on the 
background thread. This will mean the incoming commitSync()/close() will not be 
processed, resulting in possible loss of acknowledgements.
   
   To cover this case, we will now have a list of `AcknowledgeRequestStates` to 
store the `commitSyncs()` and a separate requestState to store the `close()`. 
This queue will be processed one by one until its empty. For `close()`, we are 
still assuming there can only be one active `close()` at a time.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to