mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1744338416
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -70,11 +70,10 @@
<li><a class="reference internal"
href="#optional-configuration-parameters" id="id6">Optional configuration
parameters</a>
<ul>
<li><a class="reference internal"
href="#acceptable-recovery-lag" id="id27">acceptable.recovery.lag</a></li>
- <li><a class="reference internal"
href="#default-deserialization-exception-handler"
id="id7">default.deserialization.exception.handler</a></li>
Review Comment:
I think this one was on the correct place alphabetically? Not sue why you
moved it?
Cf my other comments below (not sure how to structure this best)
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -70,11 +70,10 @@
<li><a class="reference internal"
href="#optional-configuration-parameters" id="id6">Optional configuration
parameters</a>
<ul>
<li><a class="reference internal"
href="#acceptable-recovery-lag" id="id27">acceptable.recovery.lag</a></li>
- <li><a class="reference internal"
href="#default-deserialization-exception-handler"
id="id7">default.deserialization.exception.handler</a></li>
<li><a class="reference internal" href="#default-key-serde"
id="id8">default.key.serde</a></li>
- <li><a class="reference internal"
href="#default-production-exception-handler"
id="id24">default.production.exception.handler</a></li>
Review Comment:
as above
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -292,7 +294,7 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
set by the user or all serdes must be passed in explicitly (see
also default.value.serde).</td>
<td><code class="docutils literal"><span
class="pre">null</span></code></td>
</tr>
- <tr class="row-odd"><td>default.production.exception.handler</td>
+ <tr class="row-odd"><td>default.production.exception.handler
(Deprecated. Use production.exception.handler instead.)</td>
Review Comment:
as above
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -281,7 +283,7 @@ <h4><a class="toc-backref"
href="#id23">num.standby.replicas</a><a class="header
<td colspan="2">The frequency in milliseconds with which to save
the position (offsets in source topics) of tasks.</td>
<td>30000 milliseconds (30 seconds)</td>
</tr>
- <tr
class="row-odd"><td>default.deserialization.exception.handler</td>
+ <tr class="row-odd"><td>default.deserialization.exception.handler
(Deprecated. Use deserialization.exception.handler instead.)</td>
Review Comment:
In this table, we should also insert a row for
`deserialization.exception.handler`? Which can be basically a copy of this row?
Or do we think it would be redundant? For this case, we might want to rename
this row to the new `deserialization.exception.handler`?
Not sure how to structure this nicely. Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
