mjsax commented on code in PR #17005:
URL: https://github.com/apache/kafka/pull/17005#discussion_r1741197901
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -70,9 +70,11 @@
<li><a class="reference internal"
href="#optional-configuration-parameters" id="id6">Optional configuration
parameters</a>
<ul>
<li><a class="reference internal"
href="#acceptable-recovery-lag" id="id27">acceptable.recovery.lag</a></li>
- <li><a class="reference internal"
href="#default-deserialization-exception-handler"
id="id7">default.deserialization.exception.handler</a></li>
+ <li><a class="reference internal"
href="#default-deserialization-exception-handler"
id="id7">default.deserialization.exception.handler (deprecated)</a></li>
+ <li><a class="reference internal"
href="#deserialization-exception-handler"
id="id42">deserialization.exception.handler</a></li>
<li><a class="reference internal" href="#default-key-serde"
id="id8">default.key.serde</a></li>
- <li><a class="reference internal"
href="#default-production-exception-handler"
id="id24">default.production.exception.handler</a></li>
+ <li><a class="reference internal"
href="#default-production-exception-handler"
id="id24">default.production.exception.handler (deprecated)</a></li>
+ <li><a class="reference internal"
href="#production-exception-handler"
id="id43">production.exception.handler</a></li>
Review Comment:
as above
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -70,9 +70,11 @@
<li><a class="reference internal"
href="#optional-configuration-parameters" id="id6">Optional configuration
parameters</a>
<ul>
<li><a class="reference internal"
href="#acceptable-recovery-lag" id="id27">acceptable.recovery.lag</a></li>
- <li><a class="reference internal"
href="#default-deserialization-exception-handler"
id="id7">default.deserialization.exception.handler</a></li>
+ <li><a class="reference internal"
href="#default-deserialization-exception-handler"
id="id7">default.deserialization.exception.handler (deprecated)</a></li>
+ <li><a class="reference internal"
href="#deserialization-exception-handler"
id="id42">deserialization.exception.handler</a></li>
Review Comment:
We should also insert new rows with a detailed description (guess we can
just c&p?) -- otherwise, we generate dangling links here.
##########
docs/streams/developer-guide/config-streams.html:
##########
@@ -70,9 +70,11 @@
<li><a class="reference internal"
href="#optional-configuration-parameters" id="id6">Optional configuration
parameters</a>
<ul>
<li><a class="reference internal"
href="#acceptable-recovery-lag" id="id27">acceptable.recovery.lag</a></li>
- <li><a class="reference internal"
href="#default-deserialization-exception-handler"
id="id7">default.deserialization.exception.handler</a></li>
+ <li><a class="reference internal"
href="#default-deserialization-exception-handler"
id="id7">default.deserialization.exception.handler (deprecated)</a></li>
+ <li><a class="reference internal"
href="#deserialization-exception-handler"
id="id42">deserialization.exception.handler</a></li>
Review Comment:
We should insert in alphabetical order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
