apoorvmittal10 commented on code in PR #16942:
URL: https://github.com/apache/kafka/pull/16942#discussion_r1725899005
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumeRequestManager.java:
##########
@@ -266,11 +266,18 @@ private Optional<UnsentRequest>
maybeBuildRequest(AcknowledgeRequestState acknow
return Optional.empty();
} else if (!acknowledgeRequestState.maybeExpire()) {
if (acknowledgeRequestState.canSendRequest(currentTimeMs)) {
- acknowledgeRequestState.onSendAttempt(currentTimeMs);
- if (onCommitAsync) {
- isAsyncDone.set(true);
+ UnsentRequest request =
acknowledgeRequestState.buildRequest(currentTimeMs);
Review Comment:
Agree, flatteing is better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
