AndrewJSchofield commented on code in PR #16942: URL: https://github.com/apache/kafka/pull/16942#discussion_r1723927141
########## core/src/main/java/kafka/server/share/SharePartition.java: ########## @@ -351,7 +351,7 @@ public CompletableFuture<List<AcquiredRecords>> acquire( String memberId, FetchPartitionData fetchPartitionData ) { - log.trace("Received acquire request for share partition: {}-{}", memberId, fetchPartitionData); + log.trace("Received acquire request for share partition: {}-{}", memberId, topicIdPartition); Review Comment: Ah, yes. True. The bigger problem was that fetchPartitionData doesn't have a sensible string representation so the log line was useless. What you suggested makes total sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org