brandboat commented on code in PR #16932:
URL: https://github.com/apache/kafka/pull/16932#discussion_r1724290814
##########
core/src/main/scala/kafka/log/UnifiedLog.scala:
##########
@@ -1601,7 +1601,7 @@ class UnifiedLog(@volatile var logStartOffset: Long,
shouldDelete
}
- deleteOldSegments(shouldDelete, RetentionSizeBreach(this,
remoteLogEnabled()))
+ deleteOldSegments(shouldDelete, RetentionSizeBreach(this,
remoteLogEnabledAndRemoteCopyEnabled()))
}
private def deleteLogStartOffsetBreachedSegments(): Int = {
Review Comment:
I'm not sure if this is ok as deleteLogStartOffsetBreachedSegments actually
use remoteLogEnabled instead of remoteLogEnabledAndRemoteCopyEnabled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
