brandboat opened a new pull request, #16932: URL: https://github.com/apache/kafka/pull/16932
related to https://issues.apache.org/jira/browse/KAFKA-17360 This pr fix: 1. the inconsistent "remote" flag [0][1]. we should use `remoteLogEnabledAndRemoteCopyEnabled()` 2. `-2` needs to be replaced by server-side config. [2] [0] https://github.com/apache/kafka/blob/5f02ef952e500fda5272609cec90fe1eb30da6fa/core/src/main/scala/kafka/log/UnifiedLog.scala#L1591 [1] https://github.com/apache/kafka/blob/5f02ef952e500fda5272609cec90fe1eb30da6fa/core/src/main/scala/kafka/log/UnifiedLog.scala#L1604 [2] https://github.com/apache/kafka/blob/5f02ef952e500fda5272609cec90fe1eb30da6fa/core/src/main/scala/kafka/log/UnifiedLog.scala#L2358 ### Committer Checklist (excluded from commit message) - [ ] Verify design and implementation - [ ] Verify test coverage and CI build status - [ ] Verify documentation (including upgrade notes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org