chia7712 commented on code in PR #16905:
URL: https://github.com/apache/kafka/pull/16905#discussion_r1722294637
##########
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##########
@@ -331,6 +332,28 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegrationTest with SaslSetu
assertFutureExceptionTypeEquals(results.values.get(emptyResourceNameAcl),
classOf[InvalidRequestException])
}
+ @ParameterizedTest
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testCreateDelegationTokenWithOptions(quorum: String): Unit = {
+ val owner = new KafkaPrincipal("User", "client2")
+ val renewers = List(new KafkaPrincipal("User", "client")).asJava
+ client = createAdminClient
+ val timeout = 1000
+ val options = new
CreateDelegationTokenOptions().maxlifeTimeMs(timeout).owner(owner).renewers(renewers)
Review Comment:
this is duplicate to #16648. this PR should test
"delegation.token.expiry.time.ms" and "delegation.token.max.lifetime.ms". For
example, this test case should set negative `maxlifeTimeMs` and larger
`maxlifeTimeMs` to make sure `maxTimestamp` and `expiryTimestamp` does not
exceed the configured limits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
