frankvicky commented on code in PR #16905:
URL: https://github.com/apache/kafka/pull/16905#discussion_r1720611117
##########
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##########
@@ -331,6 +332,25 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegrationTest with SaslSetu
assertFutureExceptionTypeEquals(results.values.get(emptyResourceNameAcl),
classOf[InvalidRequestException])
}
+ @ParameterizedTest
+ @ValueSource(strings = Array("zk", "kraft"))
+ def testCreateDelegationTokenWithOptions(quorum: String): Unit = {
+ client = createAdminClient
+ val timeout = 1000
+ val options = new CreateDelegationTokenOptions().maxlifeTimeMs(timeout);
+ val token = client.createDelegationToken(options).delegationToken().get()
+ assertEquals(timeout, token.tokenInfo.maxTimestamp -
token.tokenInfo.issueTimestamp)
+ }
Review Comment:
According to the test case, I think this test should cover all options, but
only the `maxlifeTimeMs` option is being tested.
Could you test the rest of them ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
