lianetm commented on PR #16673: URL: https://github.com/apache/kafka/pull/16673#issuecomment-2247971642
Hey @FrankYang0529. Thanks for the patch! I haven't reviewed this PR yet, but from a quick look: 1. yes, let's remove the unused event. Makes sense that we don't need it anymore since all happens in the background now. 2. yes, seems sensible to remove the unused `offsets` and get the offsets to commit from the subscriptionState#allConsumed directly (that we have handy when processing the assignment change event) I'll take a closer look at this PR asap in the next days. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
