lianetm commented on code in PR #16673: URL: https://github.com/apache/kafka/pull/16673#discussion_r1697102292
########## clients/src/main/java/org/apache/kafka/clients/consumer/internals/events/AssignmentChangeEvent.java: ########## @@ -16,33 +16,31 @@ */ package org.apache.kafka.clients.consumer.internals.events; -import org.apache.kafka.clients.consumer.OffsetAndMetadata; import org.apache.kafka.common.TopicPartition; -import java.util.Collections; -import java.util.Map; +import java.util.Collection; public class AssignmentChangeEvent extends ApplicationEvent { Review Comment: To be able to know when the assignment change takes effect, we should probably have to make this extend CompletableApplicationEvent (Void probably? we just need to know that it completed) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org