gharris1727 commented on code in PR #15756:
URL: https://github.com/apache/kafka/pull/15756#discussion_r1669048778
##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java:
##########
@@ -67,6 +67,7 @@ public abstract class Cast<R extends ConnectRecord<R>>
implements Transformation
+ "or value (<code>" + Value.class.getName() + "</code>).";
public static final String SPEC_CONFIG = "spec";
+ public static final String REPLACE_NULL_WITH_DEFAULT =
"replace.null.with.default";
Review Comment:
Sorry I didn't look at the previous review comments to see that this was
already discussed. I am fine with _CONFIG everywhere, or _CONFIG only in files
that have _CONFIG for the other variables. Thank you for changing this to be
more consistent!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
