gharris1727 commented on code in PR #15756:
URL: https://github.com/apache/kafka/pull/15756#discussion_r1667174184
##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/Cast.java:
##########
@@ -67,6 +67,7 @@ public abstract class Cast<R extends ConnectRecord<R>>
implements Transformation
+ "or value (<code>" + Value.class.getName() + "</code>).";
public static final String SPEC_CONFIG = "spec";
+ public static final String REPLACE_NULL_WITH_DEFAULT =
"replace.null.with.default";
Review Comment:
Config key constants are generally suffixed with `_CONFIG`
```suggestion
public static final String REPLACE_NULL_WITH_DEFAULT_CONFIG =
"replace.null.with.default";
```
Here and throughout.
##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/field/SingleFieldPath.java:
##########
@@ -181,7 +186,7 @@ public Object valueFrom(Struct struct) {
}
if (current.schema().field(lastStep()) != null) {
- return current.get(lastStep());
+ return withDefault ? current.get(lastStep()) :
current.getWithoutDefault(lastStep());
Review Comment:
nit: call lastStep once.
##########
connect/transforms/src/main/java/org/apache/kafka/connect/transforms/HeaderFrom.java:
##########
@@ -97,6 +100,7 @@ static Operation fromName(String name) {
public String toString() {
return name;
}
+
Review Comment:
nit: revert this spacing change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
