AndrewJSchofield commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1665550477
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -3956,11 +3961,482 @@ class KafkaApis(val requestChannel: RequestChannel,
}
}
+ /**
+ * Handle a shareFetch request
+ */
def handleShareFetchRequest(request: RequestChannel.Request): Unit = {
val shareFetchRequest = request.body[ShareFetchRequest]
- // TODO: Implement the ShareFetchRequest handling
- requestHelper.sendMaybeThrottle(request,
shareFetchRequest.getErrorResponse(Errors.UNSUPPORTED_VERSION.exception))
- CompletableFuture.completedFuture[Unit](())
+
+ if (!config.isNewGroupCoordinatorEnabled) {
Review Comment:
I think so, at least for now. The eventual switch will be `group.version=2`
and the second version of the new group coordinator. Unfortunately,
`group.version` has been backed out and will not be re-introduced until 4.0.
This is an internal (undocumented) config for the broker. It does the necessary
thing, which is to enable the new GC, so it seems like a safe temporary answer
here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
