chirag-wadhwa5 commented on code in PR #16456:
URL: https://github.com/apache/kafka/pull/16456#discussion_r1664144313
##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -427,6 +427,26 @@ public List<TopicIdPartition>
cachedTopicIdPartitionsInShareSession(String group
return cachedTopicIdPartitions;
}
+ /**
+ * The acknowledgeShareSessionCacheUpdate method is used to update the
share session cache before acknowledgements are handled
+ * either as part of shareFetch request or shareAcknowledge request
+ * @param groupId The group id in the request.
+ * @param memberId The member id of the client in the request.
+ * @param reqEpoch The request epoch.
+ */
+ public void acknowledgeShareSessionCacheUpdate(String groupId, Uuid
memberId, int reqEpoch) {
Review Comment:
nope, already taken care of in the latest commit. Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
