tinaselenge commented on code in PR #15175:
URL: https://github.com/apache/kafka/pull/15175#discussion_r1640046175
##########
core/src/test/scala/integration/kafka/api/SaslSslAdminIntegrationTest.scala:
##########
@@ -201,47 +216,66 @@ class SaslSslAdminIntegrationTest extends
BaseAdminIntegrationTest with SaslSetu
// Delete only ACLs on literal 'mytopic2' topic
var deleted =
client.deleteAcls(List(acl2.toFilter).asJava).all().get().asScala.toSet
- assertEquals(Set(acl2), deleted)
+ brokers.foreach { b =>
+ TestUtils.waitAndVerifyRemovedAcl(acl2.entry(),
b.dataPlaneRequestProcessor.authorizer.get, acl2.pattern())
+ }
assertEquals(Set(anyAcl, fooAcl, prefixAcl), getAcls(allTopicAcls))
ensureAcls(deleted)
// Delete only ACLs on literal '*' topic
deleted =
client.deleteAcls(List(anyAcl.toFilter).asJava).all().get().asScala.toSet
- assertEquals(Set(anyAcl), deleted)
+ brokers.foreach { b =>
+ TestUtils.waitAndVerifyRemovedAcl(anyAcl.entry(),
b.dataPlaneRequestProcessor.authorizer.get, anyAcl.pattern())
+ }
assertEquals(Set(acl2, fooAcl, prefixAcl), getAcls(allTopicAcls))
ensureAcls(deleted)
// Delete only ACLs on specific prefixed 'mytopic' topics:
deleted =
client.deleteAcls(List(prefixAcl.toFilter).asJava).all().get().asScala.toSet
- assertEquals(Set(prefixAcl), deleted)
+ brokers.foreach { b =>
+ TestUtils.waitAndVerifyRemovedAcl(prefixAcl.entry(),
b.dataPlaneRequestProcessor.authorizer.get, prefixAcl.pattern())
+ }
assertEquals(Set(anyAcl, acl2, fooAcl), getAcls(allTopicAcls))
ensureAcls(deleted)
// Delete all literal ACLs:
deleted =
client.deleteAcls(List(allLiteralTopicAcls).asJava).all().get().asScala.toSet
- assertEquals(Set(anyAcl, acl2, fooAcl), deleted)
+ brokers.foreach { b =>
+ TestUtils.waitAndVerifyRemovedAcl(anyAcl.entry(),
b.dataPlaneRequestProcessor.authorizer.get, anyAcl.pattern())
Review Comment:
Great suggestion, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
