tinaselenge commented on code in PR #15175:
URL: https://github.com/apache/kafka/pull/15175#discussion_r1640043013
##########
core/src/test/scala/integration/kafka/server/QuorumTestHarness.scala:
##########
@@ -366,6 +366,7 @@ abstract class QuorumTestHarness extends Logging {
props.setProperty(SocketServerConfigs.LISTENERS_CONFIG,
s"CONTROLLER://localhost:0")
props.setProperty(KRaftConfigs.CONTROLLER_LISTENER_NAMES_CONFIG,
"CONTROLLER")
props.setProperty(QuorumConfig.QUORUM_VOTERS_CONFIG,
s"$nodeId@localhost:0")
+ props.setProperty(ServerLogConfigs.LOG_DELETE_DELAY_MS_CONFIG, "1000")
Review Comment:
This configuration is already set on brokers via [TestUtils
class](https://github.com/apache/kafka/blob/4e2f26bfc66367877c41149f1205d301b5bef932/core/src/test/scala/unit/kafka/utils/TestUtils.scala#L346).
Without setting this on the controller as well, I was hitting
[KAFKA-16211](https://github.com/apache/kafka/blob/4e2f26bfc66367877c41149f1205d301b5bef932/core/src/test/scala/unit/kafka/utils/TestUtils.scala#L346),
which is currently being worked on, on some tests. I also thought I noticed
testCreateDeleteTopics failing without this config set to low value in the
past, but I can't seem to reproduce the failure now after running the test
several times locally. When removing this config from both brokers and
controllers, seem to work fine as well. This config was added by very old issue
[KAFKA-5099](https://issues.apache.org/jira/browse/KAFKA-5099), so maybe it's
not needed anymore. Until KAFKA-16211 is fixed, it needs to be either set to
the same value on both or removed from both.
If we remove, I would need to trigger the test a few times, to be sure there
is no flaky failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
