chia7712 commented on code in PR #16198: URL: https://github.com/apache/kafka/pull/16198#discussion_r1628123411
########## group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/GroupSpec.java: ########## @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.kafka.coordinator.group.assignor; +package org.apache.kafka.coordinator.group.api.assignor; import org.apache.kafka.common.Uuid; Review Comment: > So, we could think of using an interface though. +1 > On thing to consider is whether the MemberAssignment returned by the assignor would always be the same as the one provided to the assignor. The actual assignment (the map) is for sure. What do you think? not sure whether I have got the point. The member assignment in `GroupAssignment` returned from `PartitionAssignor#assign` is the new assignment. Hence, it should be different to assignment in `GroupSpec`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
