chia7712 commented on code in PR #16198: URL: https://github.com/apache/kafka/pull/16198#discussion_r1626582230
########## group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/GroupSpec.java: ########## @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.kafka.coordinator.group.assignor; +package org.apache.kafka.coordinator.group.api.assignor; import org.apache.kafka.common.Uuid; Review Comment: For another, `GroupSpec#MemberSubscriptionSpec` return the interface but `GroupSpec#memberAssignment` return a map struct. If it is public API now, maybe return `MemberAssignment` is more flexible if we want to enrich it in the future? ########## group-coordinator/group-coordinator-api/src/main/java/org/apache/kafka/coordinator/group/api/assignor/GroupSpec.java: ########## @@ -14,7 +14,7 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package org.apache.kafka.coordinator.group.assignor; +package org.apache.kafka.coordinator.group.api.assignor; import org.apache.kafka.common.Uuid; Review Comment: I noticed that not all interfaces have `@InterfaceStability.Unstable`. Could you share the context to me? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
