showuon commented on code in PR #16195:
URL: https://github.com/apache/kafka/pull/16195#discussion_r1626767519
##########
metadata/src/main/java/org/apache/kafka/image/TopicsDelta.java:
##########
@@ -178,13 +178,15 @@ public Set<Uuid> createdTopicIds() {
/**
* Find the topic partitions that have change based on the replica given.
- *
+ * <p>
* The changes identified are:
- * 1. deletes: partitions for which the broker is not a replica anymore
- * 2. electedLeaders: partitions for which the broker is now a leader
(leader epoch bump on the leader)
- * 3. leaders: partitions for which the isr or replicas change if the
broker is a leader (partition epoch bump on the leader)
- * 4. followers: partitions for which the broker is now a follower or
follower with isr or replica updates (partition epoch bump on follower)
- *
+ * <ul>1. deletes: partitions for which the broker is not a replica
anymore</ul>
Review Comment:
ditto
##########
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##########
@@ -118,13 +118,15 @@ public boolean hasPartitionsWithAssignmentChanges() {
/**
* Find the partitions that have change based on the replica given.
- *
+ * <p>
* The changes identified are:
- * 1. deletes: partitions for which the broker is not a replica anymore
- * 2. electedLeaders: partitions for which the broker is now a leader
(leader epoch bump on the leader)
- * 3. leaders: partitions for which the isr or replicas change if the
broker is a leader (partition epoch bump on the leader)
- * 4. followers: partitions for which the broker is now a follower or
follower with isr or replica updates (partition epoch bump on follower)
- *
+ * <ul>1. deletes: partitions for which the broker is not a replica
anymore</ul>
Review Comment:
Is it `<ul>` `<li>` ?
ref: https://blog.joda.org/2012/11/javadoc-coding-standards.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
