brandboat commented on code in PR #16195:
URL: https://github.com/apache/kafka/pull/16195#discussion_r1638220092
##########
metadata/src/main/java/org/apache/kafka/image/TopicDelta.java:
##########
@@ -118,13 +118,17 @@ public boolean hasPartitionsWithAssignmentChanges() {
/**
* Find the partitions that have change based on the replica given.
- *
+ * <p>
* The changes identified are:
- * 1. deletes: partitions for which the broker is not a replica anymore
- * 2. electedLeaders: partitions for which the broker is now a leader
(leader epoch bump on the leader)
- * 3. leaders: partitions for which the isr or replicas change if the
broker is a leader (partition epoch bump on the leader)
- * 4. followers: partitions for which the broker is now a follower or
follower with isr or replica updates (partition epoch bump on follower)
- *
+ * <ul>
+ * <li>deletes: partitions for which the broker is not a replica
anymore</li>
+ * <li>electedLeaders: partitions for which the broker is now a leader
(leader epoch bump on the leader)</li>
+ * <li>leaders: partitions for which the isr or replicas change if the
broker is a leader (partition epoch bump on the leader)</li>
+ * <li>followers: partitions for which the broker is now a follower or
follower with isr or replica updates (partition epoch bump on follower)</li>
+ * <li>topicIds: a map of topic names to topic IDs in leaders and
followers changes</li>
+ * <li>directoryIds: partitions for which directory id changes or newly
added to the broker</li>
+ * </ul>
+ * <p>
* Leader epoch bumps are a strict subset of all partition epoch bumps, so
all partitions in electedLeaders will be in leaders.
*
* @param brokerId the broker id
Review Comment:
gentle ping @showuon , could you take a look when you are available ? Thank
you ! 😃
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
