kamalcph commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1597914357
##########
storage/src/main/java/org/apache/kafka/server/log/remote/metadata/storage/ConsumerTask.java:
##########
@@ -153,6 +173,7 @@ public void run() {
private void processConsumerRecord(ConsumerRecord<byte[], byte[]> record) {
final RemoteLogMetadata remoteLogMetadata =
serde.deserialize(record.value());
+ onConsume.accept(remoteLogMetadata);
Review Comment:
Thanks for updating the test, the approach LGTM!
Nit: Why are we using the `supplier` pattern instead of adding a setter to
`TopicBasedRemoteLogMetadataManager` and marking it as `visibleForTesting`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
