satishd commented on code in PR #15885:
URL: https://github.com/apache/kafka/pull/15885#discussion_r1595738359
##########
storage/src/test/java/org/apache/kafka/server/log/remote/metadata/storage/TopicBasedRemoteLogMetadataManagerTest.java:
##########
@@ -152,15 +152,17 @@ public void testNewPartitionUpdates() throws Exception {
// RemoteLogSegmentMetadata events are already published, and
topicBasedRlmm's consumer manager will start
// fetching those events and build the cache.
- waitUntilConsumerCatchesUp(newLeaderTopicIdPartition,
newFollowerTopicIdPartition, 30_000L);
-
+ waitUntilConsumerCatchesUp(newLeaderTopicIdPartition,
newFollowerTopicIdPartition, 30_000L, 0, 0);
Assertions.assertTrue(topicBasedRlmm().listRemoteLogSegments(newLeaderTopicIdPartition).hasNext());
Assertions.assertTrue(topicBasedRlmm().listRemoteLogSegments(newFollowerTopicIdPartition).hasNext());
}
private void waitUntilConsumerCatchesUp(TopicIdPartition
newLeaderTopicIdPartition,
TopicIdPartition
newFollowerTopicIdPartition,
- long timeoutMs) throws
TimeoutException {
+ long timeoutMs,
+ long
targetLeaderMetadataPartitionOffset,
Review Comment:
These parameters will not help much here as this method was written for
`testNewPartitionUpdates` but other tests in this class used the functionality
with the gaps. It is better to relook at those usecases and refactor this
method respectively.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
