gharris1727 commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1478774161
##########
clients/src/main/java/org/apache/kafka/common/config/provider/FileConfigProvider.java:
##########
@@ -40,7 +42,13 @@ public class FileConfigProvider implements ConfigProvider {
private static final Logger log =
LoggerFactory.getLogger(FileConfigProvider.class);
+ public static final String ALLOWED_PATHS_CONFIG = "allowed.paths";
+ public static final String ALLOWED_PATHS_DOC = "A comma separated list of
paths that this config provider is " +
+ "allowed to access. If not set, all paths are allowed.";
+ private AllowedPaths allowedPaths = null;
Review Comment:
> We end up breaking tests for AbstractConfig
@tinaselenge Can you clarify what you mean here?
I think the AbstractConfig unconditionally calls configure() here
immediately after instantiation:
https://github.com/apache/kafka/blob/24a79c2613e32b1d1615f6f34d63225259740d0e/clients/src/main/java/org/apache/kafka/common/config/AbstractConfig.java#L593-L594
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
