mimaison commented on code in PR #14995:
URL: https://github.com/apache/kafka/pull/14995#discussion_r1461985813
##########
clients/src/main/java/org/apache/kafka/common/config/provider/FileConfigProvider.java:
##########
@@ -40,7 +42,13 @@ public class FileConfigProvider implements ConfigProvider {
private static final Logger log =
LoggerFactory.getLogger(FileConfigProvider.class);
+ public static final String ALLOWED_PATHS_CONFIG = "allowed.paths";
+ public static final String ALLOWED_PATHS_DOC = "A comma separated list of
paths that this config provider is " +
+ "allowed to access. If not set, all paths are allowed.";
+ private AllowedPaths allowedPaths = null;
Review Comment:
As with every `Configurable` interfaces, the implicit contract is that
`configure()` will be called before any of the other methods. I expect many
implementations would throw NPE if this wasn't the case. Searching 2 minutes I
found that it's the case in `JsonConverter` for example. I'm also not sure how
one would prevent `configure()` from being called. So I think it's fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
