Owen-CH-Leung commented on PR #14891: URL: https://github.com/apache/kafka/pull/14891#issuecomment-1890892504
> > Thanks for your feedback! Do you mean we should keep the existing API calls like createAndWaitTopic(buildTopicCommandOptionsWithBootstrap( "--create", "--partitions", "2", "--replication-factor", "1", "--topic", testTopicName)); ? > > Yes -- i think we should keep the commands Thanks. But in order to use the `createTopicWithAdmin` method defined in TestUtils, I must change the code to not use `buildTopicCommandOptionsWithBootstrap`. Having said that, there're still many places in the unit test where we use TopicCommands API to build different test cases. It's just that when creating the topic, we avoid using TopicCommands API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
